| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: doc: add examples of creative use of unique expression indexes |
| Date: | 2020-04-10 15:30:34 |
| Message-ID: | 2304.1586532634@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-docs |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> doc: add examples of creative use of unique expression indexes
> https://git.postgresql.org/pg/commitdiff/a9760d0f3cb523336b5fdd9d6c5985e39a8588a1
We had a complaint [1] that this dropped an example into the middle of
two related paragraphs. I agree with that objection, and also notice
that the extra example broke subsequent references to the "first example"
and "second example". I'm also unhappy that the other addition that this
commit made was dropped inside Example 11.3; if we're going to use
<example> markup at all, each one ought to be a coherent entity.
On top of that, I don't find that either example actually adds anything
to the discussion, as the same points are being made in the existing
text. Therefore, I don't think it's worth trying to fix these problems,
and propose just reverting this patch.
regards, tom lane
[1] https://www.postgresql.org/message-id/158648685043.655.3074746555320970574%40wrigleys.postgresql.org
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-04-10 16:00:40 | pgsql: Suppress unused-variable warning. |
| Previous Message | Alvaro Herrera | 2020-04-10 15:23:45 | Re: pgsql: Remove testing for precise LSN/reserved bytes in new TAP test |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | PG Doc comments form | 2020-04-10 17:03:49 | The line `This syntax is not as commonly used as the one above, but we show it here...` |
| Previous Message | Tom Lane | 2020-04-10 15:08:13 | Re: Difference options with the CREATE ROLE docs |