| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add a regression test for allow_system_table_mods |
| Date: | 2019-12-02 03:18:14 |
| Message-ID: | 20191202031814.GD1696@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Nov 29, 2019 at 11:09:06AM -0500, Tom Lane wrote:
> I agree that this is somewhat pointless in the case of an "unsafe" test.
> But using a different name isn't going to invalidate the test case,
> so there's not really a reason to not follow the convention. And
> trying to have an exception for unsafe_tests seems like a lot more
> trouble than it'd be worth.
Yeah, I agree that it would be just more simple to make the unsafe
test adopt the convention and be done with it. Could you fix it
please? longfin and mantid (as well as anybody running the unsafe
tests by themselves) are complaining for three days now.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-12-02 10:09:49 | Re: pgsql: Add a regression test for allow_system_table_mods |
| Previous Message | Michael Paquier | 2019-12-02 02:53:57 | pgsql: Add query cancellation capabilities in pgbench init phase |