| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Use native methods to open input in TestLib::slurp_file on Windo |
| Date: | 2019-11-26 04:41:10 |
| Message-ID: | 20191126044110.GB5435@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi Andrew,
On Sun, Nov 24, 2019 at 11:53:31PM +0000, Andrew Dunstan wrote:
> Use native methods to open input in TestLib::slurp_file on Windows.
>
> It is hoped that this will avoid some errors that we have seen before,
> but lately with greater frequency, in buildfarm animals.
>
> For now apply only to master. If this proves effective it can be
> backpatched.
>
> Discussion: https://postgr.es/m/13900.1572839580@sss.pgh.pa.us
jacana is visibly complaining about this commit:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2019-11-25%2020%3A19%3A49
The tests of commit_ts are failing:
Nov 25 16:46:52 t/001_base.........# Looks like your test exited with
255 before it could output anything.
Nov 25 16:46:52 dubious
Nov 25 16:46:52 Test returned status 255 (wstat 65280, 0xff00)
Nov 25 16:46:52 DIED. FAILED tests 1-2
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-11-26 04:43:02 | Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures |
| Previous Message | Michael Paquier | 2019-11-26 04:33:42 | pgsql: Add safeguards for pg_fsync() called with incorrectly-opened fds |