| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures |
| Date: | 2019-11-26 04:43:02 |
| Message-ID: | 20191126044302.GC5435@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi Andrew,
On Mon, Nov 25, 2019 at 09:01:46PM +0000, Andrew Dunstan wrote:
> Close stdin where it's not needed in TestLib.pm procedures
>
> Where possible, do this using a pseudoterminal, so that things like
> openssl that want to open /dev/tty if stdin isn't a tty won't.
> Elsewhere, i.e. Windows, just close by providing an empty string using
> the standard IPC::Run pipe mechanism.
>
> Patch by Andrew Dunstan, based on an idea from Craig Ringer.
>
> Reviewed by Mark Dilger.
>
> Discussion: https://postgr.es/m/873ebb57-fc98-340d-949d-691b1810bf66@2ndQuadrant.com
This one is causing failures with the TAP tests of initdb on all AIX
animals and prairiedog:
# Running: initdb --help
Can't locate IO/Pty.pm in @INC (@INC contains: ../../../src/test/perl/
. /usr/local/perl5.8.3/lib/5.8.3/darwin-2level
[...]
Unexpected SCALAR(0x1987690) in harness() parameter 7 at
../../../src/test/perl//TestLib.pm line 692
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-11-26 07:13:50 | Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures |
| Previous Message | Michael Paquier | 2019-11-26 04:41:10 | Re: pgsql: Use native methods to open input in TestLib::slurp_file on Windo |