| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Use native methods to open input in TestLib::slurp_file on Windo |
| Date: | 2019-11-26 12:53:34 |
| Message-ID: | 46c44c28-13f3-9148-56ff-ef0c1e4f0cd9@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 11/25/19 11:41 PM, Michael Paquier wrote:
> Hi Andrew,
>
> On Sun, Nov 24, 2019 at 11:53:31PM +0000, Andrew Dunstan wrote:
>> Use native methods to open input in TestLib::slurp_file on Windows.
>>
>> It is hoped that this will avoid some errors that we have seen before,
>> but lately with greater frequency, in buildfarm animals.
>>
>> For now apply only to master. If this proves effective it can be
>> backpatched.
>>
>> Discussion: https://postgr.es/m/13900.1572839580@sss.pgh.pa.us
> jacana is visibly complaining about this commit:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=jacana&dt=2019-11-25%2020%3A19%3A49
>
> The tests of commit_ts are failing:
> Nov 25 16:46:52 t/001_base.........# Looks like your test exited with
> 255 before it could output anything.
> Nov 25 16:46:52 dubious
> Nov 25 16:46:52 Test returned status 255 (wstat 65280, 0xff00)
> Nov 25 16:46:52 DIED. FAILED tests 1-2
Yeah, That's my machine so I will investigate ...
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-11-26 14:51:22 | Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures |
| Previous Message | Andrew Dunstan | 2019-11-26 12:51:50 | Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures |