| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, fn ln <emuser20140816(at)gmail(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #15977: Inconsistent behavior in chained transactions |
| Date: | 2019-09-06 07:54:15 |
| Message-ID: | 20190906075415.GA31979@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Thu, Sep 05, 2019 at 02:11:35PM -0700, Andres Freund wrote:
> On 2019-09-05 14:16:11 +0200, Peter Eisentraut wrote:
>> I'm content with this patch.
>
> Would need tests.
The latest patch sends adds coverage for all the new code paths
added. Do you have something else in mind?
>> Better disable questionable cases now and maybe re-enable them later
>> if someone wants to make a case for it.
>
> I do think the fact that COMMIT in multi-statement implicit transaction
> has some usecase, is an argument for just implementing it properly...
Like Peter, I would also keep an ERROR for now, as we could always
relax that later on.
Looking at the latest patch, the comment blocks on top of TBLOCK_STARTED
and TBLOCK_IMPLICIT_INPROGRESS in EndTransactionBlock() need an update
to mention the difference of behavior with chained transactions. And
the same comment rework should be done in UserAbortTransactionBlock()
for TBLOCK_IMPLICIT_INPROGRESS/TBLOCK_STARTED?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-09-06 17:25:36 | Re: ERROR: multixact X from before cutoff Y found to be still running |
| Previous Message | Ram Pratap Maurya | 2019-09-06 05:08:32 | RE: BUG #15992: Index size larger than the base table size. Sometime 3 times large |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-09-06 07:55:53 | Re: PostgreSQL 12 Beta 4 |
| Previous Message | Amit Langote | 2019-09-06 07:34:30 | Re: d25ea01275 and partitionwise join |