Re: d25ea01275 and partitionwise join

From: Amit Langote <amitlangote09(at)gmail(dot)com>
To: Richard Guo <riguo(at)pivotal(dot)io>
Cc: Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: d25ea01275 and partitionwise join
Date: 2019-09-06 07:34:30
Message-ID: CA+HiwqEcf2i15BpXM7k_m0RJFZo_mf5ktXMwm5t+XFOiRThttw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello Richard,

On Wed, Sep 4, 2019 at 4:30 PM Richard Guo <riguo(at)pivotal(dot)io> wrote:
>
> Hi Amit,
>
> On Wed, Sep 4, 2019 at 10:01 AM Amit Langote <amitlangote09(at)gmail(dot)com> wrote:
>>
>> Fujita-san,
>>
>> To avoid losing track of this, I've added this to November CF.
>>
>> https://commitfest.postgresql.org/25/2278/
>>
>> I know there is one more patch beside the partitionwise join fix, but
>> I've set the title to suggest that this is related mainly to
>> partitionwise joins.
>
>
> Thank you for working on this. Currently partitionwise join does not
> take COALESCE expr into consideration when matching to partition keys.
> This is a problem.
>
> BTW, a rebase is needed for the patch set.

Thanks a lot for looking at this.

I tried rebasing today and found that adopting this patch to the
following recent commit to equivalence processing code would take some
time that I don't currently have.

commit 3373c7155350cf6fcd51dd090f29e1332901e329
Author: David Rowley <drowley(at)postgresql(dot)org>
Date: Sun Jul 21 17:30:58 2019 +1200

Speed up finding EquivalenceClasses for a given set of rels

I will come back to this in a couple of weeks, along with addressing
your other comments.

Thanks,
Amit

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2019-09-06 07:54:15 Re: BUG #15977: Inconsistent behavior in chained transactions
Previous Message Kyotaro Horiguchi 2019-09-06 07:33:18 Re: Remove page-read callback from XLogReaderState.