Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc

From: Andres Freund <andres(at)anarazel(dot)de>
To: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc
Date: 2019-02-28 20:41:38
Message-ID: 20190228204138.ao7odx4qvevu63fq@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2019-02-27 10:16:21 -0800, Andres Freund wrote:
> On 2019-02-27 12:59:16 -0500, Andrew Dunstan wrote:
> > Backtraces should be enabled in the animal - I will investigate why
> > we're not getting them here. Meanwhile, here's one for this problem:
>
> Thanks, that helps! My first theories as to what's going on fell flat,
> unfortunately. I guess I'll have to figure out how to run that locally
> :(.

The issue was just that we didn't allow materializing virtual tuples
stored in a buffer tuple table slot. Locally allowing that fixed the
problem for me, I assume that'll also fix the crake. It was already on a
list of patches for pluggable storage...

Btw, shouldn't redisExecForeignDelete return NULL when there's no row
matched for the deletion? That's possible, I'd assume, if there's a
concurrent deletion.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Joe Conway 2019-02-28 20:58:50 pgsql: Make get_controlfile not leak file descriptors
Previous Message Andres Freund 2019-02-28 20:34:30 pgsql: Allow buffer tuple table slots to materialize after ExecStoreVir