Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc
Date: 2019-02-28 23:47:07
Message-ID: 5e55d328-0f1f-4629-d755-4d4c04363e45@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 2/28/19 3:41 PM, Andres Freund wrote:
> Hi,
>
> On 2019-02-27 10:16:21 -0800, Andres Freund wrote:
>> On 2019-02-27 12:59:16 -0500, Andrew Dunstan wrote:
>>> Backtraces should be enabled in the animal - I will investigate why
>>> we're not getting them here. Meanwhile, here's one for this problem:
>> Thanks, that helps! My first theories as to what's going on fell flat,
>> unfortunately. I guess I'll have to figure out how to run that locally
>> :(.
> The issue was just that we didn't allow materializing virtual tuples
> stored in a buffer tuple table slot. Locally allowing that fixed the
> problem for me, I assume that'll also fix the crake. It was already on a
> list of patches for pluggable storage...
>
> Btw, shouldn't redisExecForeignDelete return NULL when there's no row
> matched for the deletion? That's possible, I'd assume, if there's a
> concurrent deletion.
>

Yes, probably. Thanks.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-03-01 00:16:44 pgsql: Make pg_partition_tree return no rows on unsupported and undefin
Previous Message Andres Freund 2019-02-28 22:56:40 pgsql: Don't superfluously materialize slot after DELETE from an FDW.