pgsql: Allow buffer tuple table slots to materialize after ExecStoreVir

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allow buffer tuple table slots to materialize after ExecStoreVir
Date: 2019-02-28 20:34:30
Message-ID: E1gzSNy-0001hH-OT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allow buffer tuple table slots to materialize after ExecStoreVirtualTuple().

While not common, it can be useful to store a virtual tuple into a
buffer tuple table slot, and then materialize that slot. So far we've
asserted out, which surprisingly wasn't a problem for anything in
core. But that seems fragile, and it also breaks redis_fdw after
ff11e7f4b9.

Thus, allow materializing a virtual tuple stored in a buffer tuple
table slot.

Author: Andres Freund
Discussion:
https://postgr.es/m/20190227181621.xholonj7ff7ohxsg@alap3.anarazel.de
https://postgr.es/m/20180703070645.wchpu5muyto5n647@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f414abd62da7aa3cfd75e9047affd94c029c7c04

Modified Files
--------------
src/backend/executor/execTuples.c | 48 +++++++++++++++++++++++++--------------
1 file changed, 31 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2019-02-28 20:41:38 Re: pgsql: Use slots in trigger infrastructure, except for the actual invoc
Previous Message Alvaro Herrera 2019-02-28 20:23:23 pgsql: pg_dump: Fix ArchiveEntry handling of some empty values