| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, 'Christoph Berg' <christoph(dot)berg(at)credativ(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Change "checkpoint starting" message to use "wal" |
| Date: | 2018-11-30 01:16:42 |
| Message-ID: | 20181130011642.GA2267@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Nov 29, 2018 at 07:31:02PM -0500, Stephen Frost wrote:
> * Tsunakawa, Takayuki (tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com) wrote:
>> From: Christoph Berg [mailto:christoph(dot)berg(at)credativ(dot)de]
>> > A customer was complaining that the "checkpoint starting: xlog"
>> > message was not included in the grand PG10 rename of user-visible bits.
>> > The attached patch fixes that.
>>
>> Can we make use of this chance to change elog() to ereport(), so that the two messages are translated?
>
> +1, and we should probably look for nearby cases to fix also..
Good point. +1.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-11-30 01:36:43 | pgsql: Switch pg_verify_checksums back to a blacklist |
| Previous Message | Masahiko Sawada | 2018-11-30 01:02:51 | Re: [HACKERS] Moving relation extension locks out of heavyweight lock manager |