pgsql: Switch pg_verify_checksums back to a blacklist

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Switch pg_verify_checksums back to a blacklist
Date: 2018-11-30 01:36:43
Message-ID: E1gSXjX-0003Oc-VK@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Switch pg_verify_checksums back to a blacklist

This basically reverts commit d55241af705667d4503638e3f77d3689fd6be31,
leaving around a portion of the regression tests still adapted with
empty relation files, and corrupted cases. This is also proving to be
failing to check properly relation files located in a non-default
tablespace path.

Per discussion with various folks, including Stephen Frost, David
Steele, Andres Freund, Michael Banck and myself.

Reported-by: Michael Banck
Discussion: https://postgr.es/m/20181021134206.GA14282@paquier.xyz
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a1c91dd1108c2e6536935619341c79c238734f77

Modified Files
--------------
src/bin/pg_verify_checksums/pg_verify_checksums.c | 79 ++++++-----------------
src/bin/pg_verify_checksums/t/002_actions.pl | 17 -----
2 files changed, 18 insertions(+), 78 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-11-30 02:02:33 Re: pgsql: Add TAP tests for pg_verify_checksums
Previous Message Tom Lane 2018-11-29 23:28:30 pgsql: Document handling of invalid/ambiguous timestamp input near DST

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2018-11-30 01:44:33 Re: More issues with pg_verify_checksums and checksum verification in base backups
Previous Message Michael Paquier 2018-11-30 01:16:42 Re: [PATCH] Change "checkpoint starting" message to use "wal"