| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Remove dead foreign key optimization code |
| Date: | 2018-11-12 01:57:44 |
| Message-ID: | 20181112015744.xpf2aysj74ihrao4@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2018-Nov-10, Peter Eisentraut wrote:
> Remove dead foreign key optimization code
>
> The ri_KeysEqual() calls in the foreign-key trigger functions to
> optimize away some updates are useless because since
> adfeef55cbcc5dc72a772777f88c1be05a70dfee those triggers are not enqueued
> at all. (It's also not useful to keep these checks as some kind of
> backstop, since it's also semantically correct to just run the full
> check even with equal keys.)
>
> Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>
Please don't omit "Discussion:" tags from commit messages.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2018-11-12 13:44:56 | pgsql: doc: Small run-time pruning doc fix |
| Previous Message | Tom Lane | 2018-11-11 04:09:17 | Re: pgsql: Remove ineffective check against dropped columns from slot_getat |