pgsql: Remove dead foreign key optimization code

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove dead foreign key optimization code
Date: 2018-11-10 15:21:21
Message-ID: E1gLV4b-00089D-L2@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove dead foreign key optimization code

The ri_KeysEqual() calls in the foreign-key trigger functions to
optimize away some updates are useless because since
adfeef55cbcc5dc72a772777f88c1be05a70dfee those triggers are not enqueued
at all. (It's also not useful to keep these checks as some kind of
backstop, since it's also semantically correct to just run the full
check even with equal keys.)

Reviewed-by: Daniel Gustafsson <daniel(at)yesql(dot)se>

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/34479d9a36a280afe1387146871d4c1528cf2cbf

Modified Files
--------------
src/backend/utils/adt/ri_triggers.c | 51 -------------------------------------
1 file changed, 51 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-11-10 22:35:27 Re: pgsql: Remove ineffective check against dropped columns from slot_getat
Previous Message David Rowley 2018-11-10 12:11:34 Re: pgsql: Remove ineffective check against dropped columns from slot_getat