Re: pgsql: Remove ineffective check against dropped columns from slot_getat

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Remove ineffective check against dropped columns from slot_getat
Date: 2018-11-11 04:09:17
Message-ID: 19979.1541909357@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-11-11 01:11:34 +1300, David Rowley wrote:
>> Would it not be worth an Assert(!TupleDescAttr(tupleDesc, attnum -
>> 1)->attisdropped); so that we're more likely to discover any issues
>> where cached plans are not invalidated correctly?

> I don't think it'd really do much.

FWIW, I agree. We'd need assertions in many more places than this
if we wanted reasonable coverage on the point, and I doubt it's
worth the work.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2018-11-12 01:57:44 Re: pgsql: Remove dead foreign key optimization code
Previous Message Andrew Dunstan 2018-11-11 01:24:10 pgsql: Disable MSVC warning caused by recent snprintf.c changes