Re: pgsql: Fix for globals.c- c.h must come first

On 2018-06-19 13:58:34 -0400, Bruce Momjian wrote:
> On Sat, May 19, 2018 at 01:20:47AM +0000, Stephen Frost wrote:
> > Fix for globals.c- c.h must come first
> >
> > Commit da9b580 mistakenly put a system header before postgres.h (which
> > includes c.h). That can cause portability issues and broke (at least)
> > builds with older Windows compilers.
>
> I assume there is no way to add defined and checks to globals.c and c.h
> to cause a compile error when this happens.

I don't see how to do so in a form that's even halfway portable.

Just to be clear: There's nothing globals.c specific about the rule to
always include postgres.h first.

Greetings,

Andres Freund