Re: pgsql: Fix for globals.c- c.h must come first

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix for globals.c- c.h must come first
Date: 2018-06-19 17:58:34
Message-ID: 20180619175834.GE3637@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Sat, May 19, 2018 at 01:20:47AM +0000, Stephen Frost wrote:
> Fix for globals.c- c.h must come first
>
> Commit da9b580 mistakenly put a system header before postgres.h (which
> includes c.h). That can cause portability issues and broke (at least)
> builds with older Windows compilers.

I assume there is no way to add defined and checks to globals.c and c.h
to cause a compile error when this happens.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-06-19 18:03:57 Re: pgsql: Fix for globals.c- c.h must come first
Previous Message Bruce Momjian 2018-06-19 17:43:54 pgsql: doc: explain use of json_populate_record{set}()