| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| Date: | 2018-06-15 19:04:57 |
| Message-ID: | 20180615190457.fpjrfwhfoke33c3j@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2018-Jun-14, Nikhil Sontakke wrote:
> There was a slight oversight in the twophase_gid length calculation in
> the XactLogCommitRecord() code path in the cf5a1890592 commit. The
> corresponding XactLogAbortRecord() code path was ok. PFA, a small
> patch to fix the oversight.
Forgot to add: maybe it would be useful to have tests in core where
these omissions become evident. Do you have some?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-06-15 19:12:18 | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| Previous Message | Alvaro Herrera | 2018-06-15 19:04:18 | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2018-06-15 19:12:18 | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| Previous Message | Alvaro Herrera | 2018-06-15 19:04:18 | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |