| From: | Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Michael Paquier <michael(at)paquier(dot)xyz>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding |
| Date: | 2018-06-17 08:34:26 |
| Message-ID: | CAMGcDxeuvV8A4zdX6yaDiiLDUstZGujExDvs8u9ApyAFU0h0ig@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi Alvaro,
>> There was a slight oversight in the twophase_gid length calculation in
>> the XactLogCommitRecord() code path in the cf5a1890592 commit. The
>> corresponding XactLogAbortRecord() code path was ok. PFA, a small
>> patch to fix the oversight.
>
> Forgot to add: maybe it would be useful to have tests in core where
> these omissions become evident. Do you have some?
>
Thanks for the commit.
I do have some tests. They are part of the "logical decoding of 2PC"
patch which adds the needed infrastructure to *actually* use this code
present in the core as of now. I am going to submit it in the upcoming
commitfest.
Regards,
Nikhils
--
Nikhil Sontakke http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-06-17 09:02:04 | Re: pgsql: Fix memory leak in PLySequence_ToJsonbValue() |
| Previous Message | Peter Geoghegan | 2018-06-16 22:30:51 | pgsql: Remove INCLUDE attributes section from docs. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2018-06-17 10:39:30 | Re: Slow planning time for simple query |
| Previous Message | Konstantin Knizhnik | 2018-06-17 07:05:42 | Re: WAL prefetch |