Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding

From: Nikhil Sontakke <nikhils(at)2ndquadrant(dot)com>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding
Date: 2018-06-14 11:02:06
Message-ID: CAMGcDxey6dG1DP34_tJMoWPcp5sPJUAL4K5CayUUXLQSx2GQpA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi Heikki,

>
> Pushed, thanks for the review!
>

There was a slight oversight in the twophase_gid length calculation in
the XactLogCommitRecord() code path in the cf5a1890592 commit. The
corresponding XactLogAbortRecord() code path was ok. PFA, a small
patch to fix the oversight.

Regards,
Nikhils
--
Nikhil Sontakke http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
gid_length.patch application/octet-stream 576 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2018-06-14 11:03:47 pgsql: Remove cut-off bug from RunningTransactionData
Previous Message Tom Lane 2018-06-13 20:10:35 pgsql: Code review for match_clause_to_partition_key().

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2018-06-14 11:23:42 Re: why partition pruning doesn't work?
Previous Message Surafel Temesgen 2018-06-14 10:39:00 Re: ON CONFLICT DO NOTHING on pg_dump