From: | Michael Banck <michael(dot)banck(at)credativ(dot)de> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_basebackup -k option |
Date: | 2018-05-18 15:26:19 |
Message-ID: | 20180518152619.GA11887@nighthawk.caipicrew.dd-dns.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Fri, May 18, 2018 at 10:46:37AM -0400, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> > The new pg_basebackup -k option stands for --no-verify-checksums. That
> > is nearly the opposite of initdb -k, which is for enabling checksums. I
> > think it could be confusing to have two related tools use the same
> > option letter for nearly opposite purposes.
>
> > How about using capital -K in pg_basebackup? Or maybe it doesn't need a
> > short option at all.
>
> +1 for no short option.
Makes sense to me, I wasn't happy about the -k back then (and I think I
solicited feedback on that).
PFA a patch which should remove the short option.
Michael
--
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax: +49 2166 9901-100
Email: michael(dot)banck(at)credativ(dot)de
credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer
Attachment | Content-Type | Size |
---|---|---|
pg_basebackup_verify_checksums_no_short_option.patch | text/x-diff | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Magnus Hagander | 2018-05-18 15:29:53 | Re: pg_basebackup -k option |
Previous Message | Masahiko Sawada | 2018-05-18 15:21:25 | Re: [HACKERS] Transactions involving multiple postgres foreign servers |