From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Properly indent postgresql.conf comments to align |
Date: | 2016-10-27 12:37:59 |
Message-ID: | 20161027123759.GA26821@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Wed, Oct 26, 2016 at 10:23:56PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Properly indent postgresql.conf comments to align
>
> I think "properly" here is very dependent on what you believe the
> tab width is. While most of us have our editors set up for 4-space
> tabs in C files, I don't think all contributors do so for text files
> (I don't, for one). And the odds that the average user will be set up
> to edit postgresql.conf with 4-space tabs are nil.
>
> I suggest that the best way out of this might be to detab
> postgresql.conf.sample entirely, and ditto for our other sample
> config files. We could probably set up .gitattributes to make
> git complain if anyone re-introduces tabs into those files.
Uh, the postgresql.conf file is full of tabs, and they all assume
8-space tabs. I was just making those few lines consistent.
Not sure we want to remove all tabs though.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2016-10-27 13:48:37 | Re: pgsql: Properly indent postgresql.conf comments to align |
Previous Message | Peter Eisentraut | 2016-10-27 02:42:45 | pgsql: Avoid using a C++ keyword in header file |