Re: pgsql: Properly indent postgresql.conf comments to align

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Properly indent postgresql.conf comments to align
Date: 2016-10-27 02:23:56
Message-ID: 20295.1477535036@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Properly indent postgresql.conf comments to align

I think "properly" here is very dependent on what you believe the
tab width is. While most of us have our editors set up for 4-space
tabs in C files, I don't think all contributors do so for text files
(I don't, for one). And the odds that the average user will be set up
to edit postgresql.conf with 4-space tabs are nil.

I suggest that the best way out of this might be to detab
postgresql.conf.sample entirely, and ditto for our other sample
config files. We could probably set up .gitattributes to make
git complain if anyone re-introduces tabs into those files.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2016-10-27 02:42:45 pgsql: Avoid using a C++ keyword in header file
Previous Message Bruce Momjian 2016-10-27 01:17:09 pgsql: Properly indent postgresql.conf comments to align