Re: pgsql: Properly indent postgresql.conf comments to align

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Properly indent postgresql.conf comments to align
Date: 2016-10-27 13:48:37
Message-ID: 20161027134837.GA2770@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Oct 27, 2016 at 08:37:59AM -0400, Bruce Momjian wrote:
> > I suggest that the best way out of this might be to detab
> > postgresql.conf.sample entirely, and ditto for our other sample
> > config files. We could probably set up .gitattributes to make
> > git complain if anyone re-introduces tabs into those files.
>
> Uh, the postgresql.conf file is full of tabs, and they all assume
> 8-space tabs. I was just making those few lines consistent.
>
> Not sure we want to remove all tabs though.

One advantage of using tabs in postgresql.conf is that you can
add/remove comment markers on a key/value line, or add a few characters,
without causing the end-of-line comment to shift.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-10-27 16:15:05 pgsql: Fix possible pg_basebackup failure on standby with "include WAL"
Previous Message Bruce Momjian 2016-10-27 12:37:59 Re: pgsql: Properly indent postgresql.conf comments to align