| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Improve internationalization of messages involving type names |
| Date: | 2016-03-30 21:43:54 |
| Message-ID: | 20160330214354.GA48283@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Also, change them all to use the same quoting convention, namely that
> > the function name is not to be quoted but the type name is. (I'm not
> > quite sure why this is so, but it's the clear majority.)
>
> Actually, I think the general convention is to NOT quote type names
> in error messages. Certainly that's so when using format_type_be()
> to produce a name for a not-known-at-compile-time type. I would
> argue that these messages should be written to look the same as if
> format_type_be() had been used, and that would mean leaving off
> the quotes.
Ok, I'll change it.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-03-30 21:57:21 | pgsql: XLogReader general code cleanup |
| Previous Message | Tom Lane | 2016-03-30 21:25:17 | pgsql: Improve portability of I/O behavior for the geometric types. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh berkus | 2016-03-30 21:47:01 | Re: Please correct/improve wiki page about abbreviated keys bug |
| Previous Message | Julien Rouhaud | 2016-03-30 21:09:33 | Re: Publish autovacuum informations |