Re: pgsql: Improve internationalization of messages involving type names

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Improve internationalization of messages involving type names
Date: 2016-04-01 16:37:39
Message-ID: 20160401163739.GA41982@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera wrote:
> Tom Lane wrote:

> > Actually, I think the general convention is to NOT quote type names
> > in error messages. Certainly that's so when using format_type_be()
> > to produce a name for a not-known-at-compile-time type. I would
> > argue that these messages should be written to look the same as if
> > format_type_be() had been used, and that would mean leaving off
> > the quotes.
>
> Ok, I'll change it.

Done.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-01 16:39:29 Re: pgsql: Bloom index contrib module
Previous Message Alvaro Herrera 2016-04-01 16:37:11 pgsql: Type names should not be quoted

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-04-01 16:39:29 Re: pgsql: Bloom index contrib module
Previous Message Teodor Sigaev 2016-04-01 15:44:03 Re: pgsql: Bloom index contrib module