Re: pgsql: Improve internationalization of messages involving type names

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Improve internationalization of messages involving type names
Date: 2016-03-28 18:06:07
Message-ID: 10551.1459188367@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Also, change them all to use the same quoting convention, namely that
> the function name is not to be quoted but the type name is. (I'm not
> quite sure why this is so, but it's the clear majority.)

Actually, I think the general convention is to NOT quote type names
in error messages. Certainly that's so when using format_type_be()
to produce a name for a not-known-at-compile-time type. I would
argue that these messages should be written to look the same as if
format_type_be() had been used, and that would mean leaving off
the quotes.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-03-28 18:18:28 pgsql: Document errhidecontext() where it ought to be documented.
Previous Message Alvaro Herrera 2016-03-28 17:44:07 pgsql: Update expected file from quoting change

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2016-03-28 18:33:20 Re: Dealing with collation and strcoll/strxfrm/etc
Previous Message Tom Lane 2016-03-28 18:00:44 Re: [PROPOSAL] Client Log Output Filtering