| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: nodes/*funcs.c inconsistencies |
| Date: | 2015-08-03 17:00:15 |
| Message-ID: | 20150803170015.GK2441@postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Geoghegan wrote:
> Couldn't we adopt
> AssertVariableIsOfType()/AssertVariableIsOfTypeMacro() to macros like
> READ_UINT_FIELD()?
>
> I'm surprised that this stuff was only ever used for logical decoding
> infrastructure so far.
The reason it's only used there is that Andres is the one who introduced
those macros precisely for that code. We've not yet had time to adjust
the rest of the code to have more sanity checks.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2015-08-03 17:04:55 | Re: Minimum tuple threshold to decide last pass of VACUUM |
| Previous Message | Joe Conway | 2015-08-03 16:57:52 | Re: nodes/*funcs.c inconsistencies |