| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net> |
| Subject: | Re: nodes/*funcs.c inconsistencies |
| Date: | 2015-08-02 22:07:34 |
| Message-ID: | CAM3SWZT_Ugujtcmn+Zq97u5GPcdL1UGMEQxoUKaxZE46-eAtDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Aug 2, 2015 at 1:28 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> A fresh audit found the attached problems new in 9.5[1]. Most are cosmetic
> INT/UINT or field order corrections.
I was responsible for a couple of the cosmetic ones. Sorry about that.
It occurs to me that we could do a little more to prevent this
automatically. Couldn't we adopt
AssertVariableIsOfType()/AssertVariableIsOfTypeMacro() to macros like
READ_UINT_FIELD()?
I'm surprised that this stuff was only ever used for logical decoding
infrastructure so far.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-08-02 22:18:02 | Re: nodes/*funcs.c inconsistencies |
| Previous Message | Tom Lane | 2015-08-02 21:37:42 | Re: nodes/*funcs.c inconsistencies |