| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: nodes/*funcs.c inconsistencies |
| Date: | 2015-11-07 01:25:11 |
| Message-ID: | CAM3SWZSh8i+Yi9d5=xz_Q++YHe8fVtBmMfXPCPhoOSTdinYcDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 3, 2015 at 10:00 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
>> Couldn't we adopt
>> AssertVariableIsOfType()/AssertVariableIsOfTypeMacro() to macros like
>> READ_UINT_FIELD()?
>>
>> I'm surprised that this stuff was only ever used for logical decoding
>> infrastructure so far.
>
> The reason it's only used there is that Andres is the one who introduced
> those macros precisely for that code. We've not yet had time to adjust
> the rest of the code to have more sanity checks.
Any chance of picking this up, Andres?
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-11-07 02:32:48 | Minor regexp bug |
| Previous Message | Robert Haas | 2015-11-07 01:18:57 | Re: Bitmap index scans use of filters on available columns |