From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: quiet inline configure check misses a step for clang |
Date: | 2014-05-01 18:48:00 |
Message-ID: | 20140501184800.GD14243@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2014-05-01 10:10:46 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > I still think we really need to fix this. I have three possible
> > solutions:
>
> > a) Add an external file (in the source tree) that's included in the
> > configure test.
> > b) Have a compiler specific override and specify USE_INLINE there.
> > c) Drop the requirement of quiet inlines.
>
> > a) would probably the best, but I haven't yet found a non ugly solution :(
>
> Why is (a) so hard again?
>
> (If you're wondering where to put the file, I'd vote for the config/
> directory.)
Patch attached.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-quiet-inline-configure-test-on-newer-clang-compi.patch | text/x-patch | 3.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-05-01 19:16:28 | Re: Obsolete coding in fork_process.c |
Previous Message | Noah Misch | 2014-05-01 18:32:31 | Re: Obsolete coding in fork_process.c |