Re: Obsolete coding in fork_process.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Obsolete coding in fork_process.c
Date: 2014-05-01 19:16:28
Message-ID: 4013.1398971788@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah Misch <noah(at)leadboat(dot)com> writes:
> On Thu, May 01, 2014 at 12:13:28PM -0400, Tom Lane wrote:
>> Is there any reason not to change this to just fflush(NULL)? We dropped
>> support for SunOS 4.1 quite some time ago ...

> Modern systems have other fflush(NULL) problems:

> http://www.nntp.perl.org/group/perl.perl5.porters/2013/09/msg207692.html
> http://perl5.git.perl.org/metaconfig.git/blob/master:/U/perl/fflushall.U

Fun. I doubt that the postmaster's stdin would ever be a pipe, but
maybe we'd better leave well enough alone. Should update the comment
though.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-05-01 19:32:32 Re: Store data in pg_toast for custom type fails (bug?)
Previous Message Andres Freund 2014-05-01 18:48:00 Re: quiet inline configure check misses a step for clang