| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-( |
| Date: | 2014-04-28 13:47:09 |
| Message-ID: | 20140428134708.GG25695@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Can't completely get rid of #ifndef FRONTEND in palloc.h :-(
>
> pg_controldata includes postgres.h not postgres_fe.h, so utils/palloc.h
> must be able to compile in a "#define FRONTEND" context.
Hmm, I had this patch in an abandoned branch from long ago, which I
think helped remove postgres.h from pg_controldata. I remembered it
just now because of this commit message. Maybe it's useful to re-remove
the #ifndef FRONTEND from palloc.h.
It's not rebased to latest master and maybe even not complete; if people
think this approach is worthwhile I can try and clean it up and
proposely more seriously; LMK. (Also if people think it needs futher
tweaks. I vaguely recall I didn't propose it back then because the set
of stuff in the new header could be tweaked.)
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| xlogproc.patch | text/x-diff | 8.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-04-28 14:12:26 | pgsql: Minor fixes for ALTER TABLE documentation. |
| Previous Message | Tom Lane | 2014-04-28 01:24:44 | pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-( |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-04-28 13:51:56 | Re: includedir_internal headers are not self-contained |
| Previous Message | Tom Lane | 2014-04-28 13:46:28 | Re: Different behaviour of concate() and concate operator || |