| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [COMMITTERS] pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-( |
| Date: | 2014-04-28 14:30:22 |
| Message-ID: | 10551.1398695422@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
> Tom Lane wrote:
>> pg_controldata includes postgres.h not postgres_fe.h, so utils/palloc.h
>> must be able to compile in a "#define FRONTEND" context.
> Hmm, I had this patch in an abandoned branch from long ago, which I
> think helped remove postgres.h from pg_controldata. I remembered it
> just now because of this commit message. Maybe it's useful to re-remove
> the #ifndef FRONTEND from palloc.h.
Hm. It would certainly be better if pg_controldata could use
postgres_fe.h not postgres.h, but I'm confused about how the new header
added by this patch helps that? None of the declarations you removed from
xlog.h look like they'd be more problematic than the ones you left behind.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2014-04-28 14:32:45 | pgsql: Fix two bugs in WAL-logging of GIN pending-list pages. |
| Previous Message | Robert Haas | 2014-04-28 14:12:26 | pgsql: Minor fixes for ALTER TABLE documentation. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2014-04-28 14:31:32 | Re: Minor improvement to fdwhandler.sgml |
| Previous Message | Robert Haas | 2014-04-28 14:27:41 | Re: bgworker crashed or not? |