Re: Minor improvement to fdwhandler.sgml

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Minor improvement to fdwhandler.sgml
Date: 2014-04-28 14:31:32
Message-ID: CA+TgmobmhOikNrb1x_Ub2p0+mb4DHksS6RxVvaqBotWKDc6tjQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Apr 24, 2014 at 7:59 AM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> The patch attached improves docs in fdwhandler.sgml a little bit.

When you submit a patch, it's helpful to describe what the patch
actually does, rather than just saying it makes things better. For
example, I think that this patch could be described as "in
fdwhandler.sgml, mark references to scan_clauses with <structfield>
tags".

A problem with that idea is that scan_clauses is not a field in any struct.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2014-04-28 14:39:09 Re: [COMMITTERS] pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(
Previous Message Tom Lane 2014-04-28 14:30:22 Re: [COMMITTERS] pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(