pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(
Date: 2014-04-28 01:24:44
Message-ID: E1WeaJI-0006gF-EW@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Can't completely get rid of #ifndef FRONTEND in palloc.h :-(

pg_controldata includes postgres.h not postgres_fe.h, so utils/palloc.h
must be able to compile in a "#define FRONTEND" context. It appears that
Solaris Studio is smart enough to persuade us to define PG_USE_INLINE,
but not smart enough to not make a copy of unreferenced static functions;
which leads to an unsatisfied reference to CurrentMemoryContext. So we
need an #ifndef FRONTEND around that declaration. Per buildfarm.

Branch
------
REL9_3_STABLE

Details
-------
http://git.postgresql.org/pg/commitdiff/36825f38dd44d8630b07be843dfc1619fe9f8d5c

Modified Files
--------------
src/include/utils/palloc.h | 7 +++++++
1 file changed, 7 insertions(+)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2014-04-28 13:47:09 Re: pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(
Previous Message Tom Lane 2014-04-26 19:11:14 pgsql: Improve generation algorithm for database system identifier.

Browse pgsql-hackers by date

  From Date Subject
Next Message Rajeev rastogi 2014-04-28 04:17:44 Re: So why is EXPLAIN printing only *plan* time?
Previous Message Tom Lane 2014-04-27 22:44:16 Re: Composite Datums containing toasted fields are a bad idea(?)