Re: pgsql: Get rid of the dynamic shared memory state file.

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Robert Haas <rhaas(at)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Get rid of the dynamic shared memory state file.
Date: 2014-04-08 20:14:34
Message-ID: 20140408201434.GY4161@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2014-04-08 15:45:39 +0000, Robert Haas wrote:
> Get rid of the dynamic shared memory state file.
>
> Instead of storing the ID of the dynamic shared memory control
> segment in a file within the data directory, store it in the main
> control segment. This avoids a number of nasty corner cases,
> most seriously that doing an online backup and then using it on
> the same machine (e.g. to fire up a standby) would result in the
> standby clobbering all of the master's dynamic shared memory
> segments.
>
> Per complaints from Heikki Linnakangas, Fujii Masao, and Tom
> Lane.

Looks like it's not working for windows yet:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2014-04-08%2016%3A31%3A18
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=baiji&dt=2014-04-08%2017%3A00%3A01

There's also the to_reg* commit in the ones tested by those runs, but it
sounds unlikely that those would trigger during initdb.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2014-04-08 20:17:46 Re: pgsql: Get rid of the dynamic shared memory state file.
Previous Message Tom Lane 2014-04-08 19:49:07 pgsql: Add an in-core GiST index opclass for inet/cidr types.