From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: Get rid of the dynamic shared memory state file. |
Date: | 2014-04-08 20:17:46 |
Message-ID: | CA+Tgmobq2TK18_Q18ps+5i-=30eDNu7nhYMofFW3KKFrd+dN7Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Tue, Apr 8, 2014 at 4:14 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
> On 2014-04-08 15:45:39 +0000, Robert Haas wrote:
>> Get rid of the dynamic shared memory state file.
>>
>> Instead of storing the ID of the dynamic shared memory control
>> segment in a file within the data directory, store it in the main
>> control segment. This avoids a number of nasty corner cases,
>> most seriously that doing an online backup and then using it on
>> the same machine (e.g. to fire up a standby) would result in the
>> standby clobbering all of the master's dynamic shared memory
>> segments.
>>
>> Per complaints from Heikki Linnakangas, Fujii Masao, and Tom
>> Lane.
>
> Looks like it's not working for windows yet:
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2014-04-08%2016%3A31%3A18
> http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=baiji&dt=2014-04-08%2017%3A00%3A01
>
> There's also the to_reg* commit in the ones tested by those runs, but it
> sounds unlikely that those would trigger during initdb.
Crap. I did test that it worked with EXEC_BACKEND, but I don't have a
Windows environment set up. I can try to eyeball the code and see
what might be wrong with it, but...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2014-04-08 20:20:08 | Re: pgsql: Get rid of the dynamic shared memory state file. |
Previous Message | Andres Freund | 2014-04-08 20:14:34 | Re: pgsql: Get rid of the dynamic shared memory state file. |