From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Get rid of the dynamic shared memory state file. |
Date: | 2014-04-08 15:45:39 |
Message-ID: | E1WXYDT-0006yT-0Y@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Get rid of the dynamic shared memory state file.
Instead of storing the ID of the dynamic shared memory control
segment in a file within the data directory, store it in the main
control segment. This avoids a number of nasty corner cases,
most seriously that doing an online backup and then using it on
the same machine (e.g. to fire up a standby) would result in the
standby clobbering all of the master's dynamic shared memory
segments.
Per complaints from Heikki Linnakangas, Fujii Masao, and Tom
Lane.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/11a65eed1637a05b03e174700799b024e104bfb4
Modified Files
--------------
src/backend/port/sysv_shmem.c | 12 ++-
src/backend/port/win32_shmem.c | 6 +-
src/backend/storage/ipc/dsm.c | 200 ++++++++--------------------------------
src/backend/storage/ipc/ipci.c | 6 +-
src/include/storage/dsm.h | 8 +-
src/include/storage/pg_shmem.h | 5 +-
6 files changed, 71 insertions(+), 166 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2014-04-08 15:47:57 | pgsql: doc: Fix typo. |
Previous Message | Robert Haas | 2014-04-08 14:33:38 | pgsql: Add new to_reg* functions for error-free OID lookups. |