Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update

Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Avoid resetting Xmax when it's a multi with an aborted update
>
> I may be confused, but this patch doesn't look like it does what
> your commit log message says. It looks to me like the logic for
> setting the hint bit is exactly the same as before; what's changed
> is only the return code from HeapTupleSatisfiesUpdate.
>
> The code looks right, though. Is it just that your commit message
> misdescribes it?

You're right, I got the commit message wrong. The problem is still that
locks can go "ignored" (if not "forgotten") due to the wrong return
code.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services