| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)postgresql(dot)org |
| Subject: | pgsql: Clear retry flags properly in replacement OpenSSL sock_write fun |
| Date: | 2013-12-05 17:49:12 |
| Message-ID: | E1Vod32-00006i-Ta@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Clear retry flags properly in replacement OpenSSL sock_write function.
Current OpenSSL code includes a BIO_clear_retry_flags() step in the
sock_write() function. Either we failed to copy the code correctly, or
they added this since we copied it. In any case, lack of the clear step
appears to be the cause of the server lockup after connection loss reported
in bug #8647 from Valentine Gogichashvili. Assume that this is correct
coding for all OpenSSL versions, and hence back-patch to all supported
branches.
Diagnosis and patch by Alexander Kukushkin.
Branch
------
REL9_0_STABLE
Details
-------
http://git.postgresql.org/pg/commitdiff/36352ceb40bd6b19b0595f7d8bb93cc64897abbb
Modified Files
--------------
src/backend/libpq/be-secure.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-12-05 17:49:13 | pgsql: Clear retry flags properly in replacement OpenSSL sock_write fun |
| Previous Message | Alvaro Herrera | 2013-12-05 16:42:26 | Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update |