Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update
Date: 2013-12-05 16:15:53
Message-ID: 16887.1386260153@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Avoid resetting Xmax when it's a multi with an aborted update

I may be confused, but this patch doesn't look like it does what
your commit log message says. It looks to me like the logic for
setting the hint bit is exactly the same as before; what's changed
is only the return code from HeapTupleSatisfiesUpdate.

The code looks right, though. Is it just that your commit message
misdescribes it?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2013-12-05 16:42:26 Re: pgsql: Avoid resetting Xmax when it's a multi with an aborted update
Previous Message Alvaro Herrera 2013-12-05 16:05:46 pgsql: Avoid resetting Xmax when it's a multi with an aborted update