| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Fix for pg_upgrade and invalid indexes |
| Date: | 2013-03-30 17:01:34 |
| Message-ID: | 20130330170134.GA23500@alap2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 2013-03-29 19:03:05 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > Those columns cannot be NULL, so using IS DISTINCT FROM seems a bit
> > clumsy.
>
> That was what I started to write, too, but actually I think the IS
> DISTINCT is correct and the RIGHT JOIN should be a LEFT JOIN. Note
> that the query appears to be intended to collect regular tables as
> well as indexes. (As patched, that's totally broken, so I infer
> Bruce hasn't tested it yet.)
Ah yes. Then I'd actually find it much more readable to formulate it as a NOT
EXISTS(), but that might be just me.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-03-30 18:23:54 | pgsql: Improve code documentation about "magnetic disk" storage manager |
| Previous Message | Andrew Dunstan | 2013-03-30 16:55:15 | pgsql: Avoid moving data directory in upgrade testing. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Satoshi Nagayasu | 2013-03-30 17:12:59 | Re: By now, why PostgreSQL 9.2 don't support SSDs? |
| Previous Message | Tom Lane | 2013-03-30 16:54:36 | Re: By now, why PostgreSQL 9.2 don't support SSDs? |