| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Fix for pg_upgrade and invalid indexes |
| Date: | 2013-03-29 23:03:05 |
| Message-ID: | 6274.1364598185@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> Those columns cannot be NULL, so using IS DISTINCT FROM seems a bit
> clumsy.
That was what I started to write, too, but actually I think the IS
DISTINCT is correct and the RIGHT JOIN should be a LEFT JOIN. Note
that the query appears to be intended to collect regular tables as
well as indexes. (As patched, that's totally broken, so I infer
Bruce hasn't tested it yet.)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-03-29 23:22:24 | Re: pgsql: Add sql_drop event for event triggers |
| Previous Message | Andres Freund | 2013-03-29 22:40:28 | Re: Fix for pg_upgrade and invalid indexes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Farina | 2013-03-29 23:16:12 | Re: Getting to 9.3 beta |
| Previous Message | Andres Freund | 2013-03-29 22:40:28 | Re: Fix for pg_upgrade and invalid indexes |