Re: typedefs for indent

Andrew Dunstan wrote:
> >>> FWIW I was looking at this code for unrelated reasons and found a couple
> >>> of symbols that pgindent considers to be typedefs but it clearly are not
> >>> -- BufferHitCount and LocalBufferHitCount. It can be seen in
> >>> ShowBufferUsage().
> >>>
> >> Are you saying you saw this in Andrew's typedef output, or from the 8.3
> >> run of pg_indent?
> >>
> >
> > This is on the 8.3 code. Notice how this is formatted:
> >
> > hitrate = (float) BufferHitCount *100.0 / ReadBufferCount;
> >
> >
> >
> >
>
>
> These symbols are not in the buildfarm's list of typedefs.

The good news is that LocalBufferHitCount isn't in my list of typedefs
from CVS HEAD, and probably not in 8.3 either. The bad news is that
pgindent pushes the '*' next to the 100.0 in my testing. :-(

I tested BSD indent alone with no arguments or typedef list and got the
same output, even after adding the space in the C file, so something
wrong must be happening in the binary.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +