| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: typedefs for indent |
| Date: | 2009-03-30 22:45:37 |
| Message-ID: | 24929.1238453137@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Andrew Dunstan wrote:
>> This is on the 8.3 code. Notice how this is formatted:
>>
>> hitrate = (float) BufferHitCount *100.0 / ReadBufferCount;
> The good news is that LocalBufferHitCount isn't in my list of typedefs
> from CVS HEAD, and probably not in 8.3 either. The bad news is that
> pgindent pushes the '*' next to the 100.0 in my testing. :-(
It's the (float), possibly in combination with the *, that does that.
There are many occurrences of this with other type names, eg (double).
I think it's too dumb to figure out that this is a cast and not a
variable declaration.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2009-03-31 00:34:50 | can't load plpython |
| Previous Message | Bruce Momjian | 2009-03-30 22:09:54 | Re: typedefs for indent |