| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: typedefs for indent |
| Date: | 2009-03-30 21:54:02 |
| Message-ID: | 49D13F7A.8010701@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera wrote:
> Bruce Momjian wrote:
>
>> Alvaro Herrera wrote:
>>
>>> Bruce Momjian wrote:
>>>
>>>
>>>> Thanks. I will run tests when we are ready for pg_indent and we can
>>>> then make a decision.
>>>>
>>> FWIW I was looking at this code for unrelated reasons and found a couple
>>> of symbols that pgindent considers to be typedefs but it clearly are not
>>> -- BufferHitCount and LocalBufferHitCount. It can be seen in
>>> ShowBufferUsage().
>>>
>> Are you saying you saw this in Andrew's typedef output, or from the 8.3
>> run of pg_indent?
>>
>
> This is on the 8.3 code. Notice how this is formatted:
>
> hitrate = (float) BufferHitCount *100.0 / ReadBufferCount;
>
>
>
>
These symbols are not in the buildfarm's list of typedefs.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2009-03-30 22:01:30 | Re: typedefs for indent |
| Previous Message | Alvaro Herrera | 2009-03-30 21:39:38 | Re: typedefs for indent |