Re: wrong behavior using to_char() again

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Euler Taveira de Oliveira <euler(at)timbira(dot)com>
Cc: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: wrong behavior using to_char() again
Date: 2007-11-21 16:17:05
Message-ID: 20071121161705.GB12726@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Euler Taveira de Oliveira wrote:
> Hi,
>
> Looking again at bug report [1], I agree that's a glibc bug. Numbers in
> pt_BR has its format 1.234.567,89; sometimes the format 1234567,89 is
> acceptable too, ie, the thousand separator is optional. I guess that
> some locales use the 'optional' thousand separator too (yep, they are
> all broken too).

Yeah, formatting.c revs 1.106 and 1.105 contains this (it was already
pointed out in the previous thread):

revision 1.106
date: 2006-02-12 20:48:23 -0300; author: momjian; state: Exp; lines: +3 -4;
Revert because C locale uses "" for thousands_sep, meaning "n/a", while
French uses "" for "don't want". Seems we have to keep the existing
behavior.
----------------------------
revision 1.105
date: 2006-02-12 16:52:06 -0300; author: momjian; state: Exp; lines: +5 -4;
Support "" for thousands separator and plus sign in to_char(), per
report from French Debian user. psql already handles "" fine.

I'm not sure that your proposed patch is OK for the C locale. It was
proposed that the C locale should be handled as an exception, but it
seems nothing got done in that direction.

Are we going to do something for 8.3?

--
Alvaro Herrera http://www.amazon.com/gp/registry/CTMLCN8V17R4
"La experiencia nos dice que el hombre peló millones de veces las patatas,
pero era forzoso admitir la posibilidad de que en un caso entre millones,
las patatas pelarían al hombre" (Ijon Tichy)

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2007-11-21 16:18:35 Re: Postgres 8.3 archive_command
Previous Message Albe Laurenz 2007-11-21 15:29:57 Re: backup_label and server start

Browse pgsql-patches by date

  From Date Subject
Next Message Matteo Beccati 2007-11-21 16:30:37 Re: Better default_statistics_target
Previous Message Zdenek Kotala 2007-11-21 13:39:30 Re: Fix pg_dump dependency on postgres.h