| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Fix pg_dump dependency on postgres.h |
| Date: | 2007-11-21 13:39:30 |
| Message-ID: | 47443512.7090308@sun.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
> Tom Lane wrote:
>> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
>>> Huh, I think the point is to be able to build 8.3 at all on certain
>>> Solaris releases. I think it qualifies as a portability fix.
>> (a) it wasn't "to build at all", it was to allow "inline" to be enabled
>> on Sun Studio's compiler, which apparently is too dumb to not generate
>> copies of an unreferenced inline function.
>>
>> (b) portability fix or not, this ain't going into 8.3. It's *far* too
>> invasive for this late stage of the cycle.
>
> Yea, that was my analysis too.
>
Yes, I agree with Bruce and Tom. It is more invasive then I expected.
And specially in context when pg_resetxlog needs to be also fixed and
this fix seems more complicated then pg_dump fix :(.
Zdenek
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rudolf van der Leeden | 2007-11-21 13:45:27 | Postgres 8.3 archive_command |
| Previous Message | Simon Riggs | 2007-11-21 13:33:52 | Re: backup_label and server start |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2007-11-21 16:17:05 | Re: wrong behavior using to_char() again |
| Previous Message | CN | 2007-11-21 13:15:21 | BUG #3770: Follow up: Fail to make bcc32.mak for libpq |