Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link
Date: 2007-11-13 18:37:56
Message-ID: 20071113183756.GD19014@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Bruce Momjian wrote:
> Tom Lane wrote:
> > Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > > Am Samstag, 10. November 2007 schrieb Bruce Momjian:
> > >> Use strip -x on OS/X-darwin because non-"-x" causes link problems:
> >
> > > How will this work, considering that $template isn't set anywhere?
> >
> > It won't, of course. Perhaps something like
> >
> > if test `uname -s` = Darwin
> >
> > instead.
>
> I am afraid some unames don't have -s, so I did uname -a and tested for
> it starting with Darwin. Patch attached and applied.

Hmm, this doesn't seem to work for me:

$ if test expr "`uname -a`" : 'Darwin' -ne 0
> then stripprog="${STRIPPROG-strip -x}"
> else stripprog="${STRIPPROG-strip}"
> fi
-bash: test: too many arguments

--
Alvaro Herrera http://www.amazon.com/gp/registry/5ZYLFMCVHXC
"La naturaleza, tan frágil, tan expuesta a la muerte... y tan viva"

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2007-11-13 18:44:20 pgsql: Add link to Postgres-R glossary from our documentation (has
Previous Message Bruce Momjian 2007-11-13 18:15:53 Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2007-11-13 18:50:55 Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link
Previous Message Bruce Momjian 2007-11-13 18:15:53 Re: [HACKERS] pgsql: Use strip -x on OS/X-darwin because non-"-x" causes link